Use serde to deserialize program arguments #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
m-kus
force-pushed
the
feat/program-args-serde
branch
from
4c25966 to
b258420
Compare
m-kus
force-pushed
the
feat/program-args-serde
branch
from
b258420 to
2f4ee98
Compare
m-kus
force-pushed
the
feat/program-args-serde
branch
from
2f4ee98 to
49cc6d2
Compare
m-kus
force-pushed
the
feat/program-args-serde
branch
from
49cc6d2 to
a843805
Compare
maciejka
approved these changes
Sep 6, 2024
Great thing about shell is that you can copy paste specific lines to the terminal and run commands that you need, so it’s sort of an instruction. i think that as long they are used just for orchestration it is fine. longer term i would prefer rust (we can use typed python, it’s just hard to enforce) especially if we end up having custom runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we initialize the Cairo memory directly using the information about layouts of the types we use.
However, there are two issues with this approach:
This PR uses Serde to deserialize program arguments properly.